Add a @gapic_third_party indirection to the gapic build.#2447
Merged
pmuetschard merged 1 commit intogoogle:masterfrom Dec 12, 2018
Merged
Add a @gapic_third_party indirection to the gapic build.#2447pmuetschard merged 1 commit intogoogle:masterfrom
@gapic_third_party indirection to the gapic build.#2447pmuetschard merged 1 commit intogoogle:masterfrom
Conversation
Member
Author
|
Let me know if this helps with the maven deps. |
Contributor
|
hmm, I don't know if this will be helpful. Generally what I have to do is manually downloading all the dependencies, then create In this way, for most dependencies, the BUILD file and WORKSPACE file will also have their local copies, so the package structure won't change. |
Member
Author
|
Well, the point of this change is that you no longer have to do that! You now have lots of options:
|
Contributor
|
Great, thanks, this definitely helps a lot. |
qining
approved these changes
Dec 11, 2018
qining
approved these changes
Dec 11, 2018
AWoloszyn
approved these changes
Dec 12, 2018
Makes overriding of where the gapic dependencies come from a bit easier.
ddf25be to
7206803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes overriding of where the gapic dependencies come from a bit easier.