Handle (some) PLT type functions in libInterceptor.#2416
Merged
pmuetschard merged 6 commits intogoogle:masterfrom Dec 5, 2018
Merged
Handle (some) PLT type functions in libInterceptor.#2416pmuetschard merged 6 commits intogoogle:masterfrom
pmuetschard merged 6 commits intogoogle:masterfrom
Conversation
The workaround is broken, because of linker namespaces not allowing loading `/system/lib/libhwgl.so` anyways.
... and clang-format them.
The order in the code was reversed.
Instead of only being limited to register X17, also be able to use the other scratch register (X16) and the caller saved registers (X9-X15).
Implemented for armeabi-v7 and arm64-v8, if the first instruction of the function is an unconditional branch, attempt to modify the target of that branch instead of the original function. Thus the codepath will be: `App->driver->branch->trampoline->spy->compensation function->driver`
AWoloszyn
approved these changes
Dec 5, 2018
Contributor
AWoloszyn
left a comment
There was a problem hiding this comment.
I will give this a test on my devices today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented for armeabi-v7 and arm64-v8, if the first instruction of the function is an unconditional branch, attempt to modify the target of that branch instead of the original function. Thus the codepath will be:
App->driver->branch->trampoline->spy->compensation function->driverSee #355