Vulkan: Fix BasePipeline value set in vkCreate*Pipelines#2393
Merged
bjoeris merged 1 commit intogoogle:masterfrom Nov 26, 2018
Merged
Vulkan: Fix BasePipeline value set in vkCreate*Pipelines#2393bjoeris merged 1 commit intogoogle:masterfrom
BasePipeline value set in vkCreate*Pipelines#2393bjoeris merged 1 commit intogoogle:masterfrom
Conversation
AWoloszyn
approved these changes
Nov 23, 2018
When the `vk*PipelineCreateInfo` specifies a base pipeline by `basePipelineHandle`, the `basePipelineIndex` is set to -1; the previous code lost this -1 value, and later in `vk*PipelineCreateInfo`, `BasePipelineIndex` was 0, causing `BasePipeline` to be set by index, instead of by handle. This change ensures that `basePipelineIndex` is copied over to the `*PipelineObject`, so that `BasePipeline` is set correctly. Fixes google#2392
bjoeris
force-pushed
the
pr-base-pipeline
branch
from
0b3acbc to
3838a57
Compare
bjoeris
added
kokoro:run
kokoro:force-run
and removed
kokoro:force-run
kokoro:run
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
vk*PipelineCreateInfospecifies a base pipeline bybasePipelineHandle, thebasePipelineIndexis set to -1; the previous codelost this -1 value, and later in
vk*PipelineCreateInfo,BasePipelineIndexwas 0, causing
BasePipelineto be set by index, instead of by handle.This change ensures that
basePipelineIndexis copied over to the*PipelineObject, so thatBasePipelineis set correctly.Fixes #2392