Most gapit verbs can now take a capture ID instead of a gfxtrace file.#2337
Merged
AWoloszyn merged 3 commits intogoogle:masterfrom Nov 1, 2018
Merged
Most gapit verbs can now take a capture ID instead of a gfxtrace file.#2337AWoloszyn merged 3 commits intogoogle:masterfrom
AWoloszyn merged 3 commits intogoogle:masterfrom
Conversation
Contributor
|
You could add a boolean flag to gapit, (--capture-id) that just tells gapit that the given string is a capture-id instead of a file. We have several boolean flags already, and this would make it more unambiguous. (-noopt for example). |
ben-clayton
reviewed
Oct 31, 2018
paulthomson
changed the title
Contributor
Author
|
Talked with Ben. Made most gapit verbs be able to take a capture ID. If you add -captureid, the capture arg will be interpreted as a capture ID instead of a capture file path. Most verbs get gapis and load a trace, so created a |
Contributor
Author
|
I also added another change: |
AWoloszyn
approved these changes
Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to be able to pass a capture ID and a gapis-port to
gapit screenshotso that it will take a screenshot of some capture that is already loaded. This avoids me having to wait 5 mins per screenshot to load the capture; instead, I can load it once from disk and then refer to it later via its capture ID. I would also like to modify (i.e. create mutated versions of) captures in gapis without writing them to disk, so this PR will be useful in this scenario.Slightly weird: since the capture file is a positional/non-flag argument, I am attempting to parse it as a hex string (capture ID) and, if that fails, treating it as a file as before. If you have a filename that happens to be a hex string, you could use e.g. "./0000FFFFF". Could alternatively use a flag and then expect no positional args.