Vulkan: Smarter check for temporary shader modules, renderpasses etc.#2235
Merged
qining merged 1 commit intogoogle:masterfrom Sep 20, 2018
Merged
Conversation
When rebuilding the initial commands for pipelines, there might be shader modules and renderpasses with the same handle value as the ones in pipelines, but actually means different content. For such cases, we should also create temporary shader modules and renderpasses
AWoloszyn
approved these changes
Sep 20, 2018
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
Are these all of the temporaries in our state reconstruction or are there more? (I.e. should we be making this fix in more places)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rebuilding the initial commands for pipelines, there might be
shader modules and renderpasses with the same handle value as the ones in
pipelines, but actually means different content. For such cases, we
should also create temporary shader modules and renderpasses