Vulkan: Fix incorrect traversal of descriptor bindings#2226
Merged
qining merged 1 commit intogoogle:masterfrom Sep 18, 2018
Merged
Vulkan: Fix incorrect traversal of descriptor bindings#2226qining merged 1 commit intogoogle:masterfrom
qining merged 1 commit intogoogle:masterfrom
Conversation
Descriptor bindings are not 'consecutive numbers starting from 0'. Should use `for _, binding_number, binding in descriptor_set.Bindings` instead of `for i in (0 .. len(descriptor_set.Bindings))` to traverse through the maps. This also allow us to drop the duplicated memory-read for buffers when binding descriptor sets.
AWoloszyn
approved these changes
Sep 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptor bindings are not 'consecutive numbers starting from 0'.
Should use
for _, binding_number, binding in descriptor_set.Bindingsinstead of
for i in (0 .. len(descriptor_set.Bindings))to traversethrough the maps.
This also allow us to drop the duplicated memory-read for buffers when
binding descriptor sets.