Vulkan: re-Fix wrong descriptor set indices when binding descriptor sets#2224
Merged
qining merged 1 commit intogoogle:masterfrom Sep 18, 2018
Merged
Vulkan: re-Fix wrong descriptor set indices when binding descriptor sets#2224qining merged 1 commit intogoogle:masterfrom
qining merged 1 commit intogoogle:masterfrom
Conversation
This re-fixes the wrong calculation of descriptor set indices when binding descriptor sets. The fix was reverted as google#2191 get reverted. Also, for multi-layer maps (e.g. `map!(u32, map!(u32...`), we need to explicitly assign the child map back to the parent map. This is because the generated go/c++ code will not assign the child map back to the parent map automactically (go: `Get()`, c++: `findOrZero`) when write api file like: `parent[parent_key][child_key] = child_content`. TODO: Similar bugs for other mutlti-layer maps
AWoloszyn
approved these changes
Sep 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-fixes the wrong calculation of descriptor set indices when binding
descriptor sets. The fix was reverted as #2191 get reverted.
Also, for multi-layer maps (e.g.
map!(u32, map!(u32...), we need toexplicitly assign the child map back to the parent map. This is because
the generated go/c++ code will not assign the child map back to the
parent map automactically (go:
Get(), c++:findOrZero) when writeapi file like:
parent[parent_key][child_key] = child_content.TODO: Similar bugs for other mutlti-layer maps