Another way to drop raw bytes of the capture data#2186
Merged
qining merged 1 commit intogoogle:masterfrom Sep 18, 2018
Merged
Conversation
qining
changed the title
Contributor
Author
|
@ben-clayton Any suggestions about this CL? |
ben-clayton
approved these changes
Sep 18, 2018
Contributor
ben-clayton
left a comment
ben-clayton
left a comment
There was a problem hiding this comment.
Sorry for the slow review.
I like this solution. Good stuff!
Please can you squash the top two CLs? Having the intermediate form appears to serve no purpose and just litters the git history.
| return e.encode(ctx) | ||
| } | ||
|
|
||
| type Source interface { |
gapis/capture/capture.go
Outdated
| bytes.Reader | ||
| } | ||
|
|
||
| func (brc *blobReadCloser) Close() error { |
Contributor
There was a problem hiding this comment.
Übernit: You can drop the brc * bit of the receiver.
gapis/capture/capture.go
Outdated
| } | ||
|
|
||
| func (b *Blob) ReadCloser() (io.ReadCloser, error) { | ||
| return &blobReadCloser{*bytes.NewReader(b.GetData())}, nil |
Contributor
There was a problem hiding this comment.
Übernit: Make bytes.Reader field a pointer (*bytes.Reader), you can drop the indirection stuff:
return blobReadCloser{bytes.NewReader(b.GetData())}, nil
qining
force-pushed
the
another-way-do-not-cache-capture-data
branch
from
e65364b to
41cb2b7
Compare
Contributor
Author
|
Yep, I always squash and rebase for CLs. |
ben-clayton
added a commit
to ben-clayton/gapid
that referenced
this pull request
Sep 19, 2018
ben-clayton
added a commit
that referenced
this pull request
Sep 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another approach to do the same thing as #2179