Do not cache the instruction builder for replay execution#2170
Merged
qining merged 3 commits intogoogle:masterfrom Sep 4, 2018
Merged
Do not cache the instruction builder for replay execution#2170qining merged 3 commits intogoogle:masterfrom
qining merged 3 commits intogoogle:masterfrom
Conversation
The builder will be kept alive until the replay is done on the device, while the encoded instructions and resources can be freed before the replay gets started.
notification readers
qining
changed the title
AWoloszyn
approved these changes
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this CL, a builder is kept as the closures for postback decoders and notification readers capture the builder, so the instructions and other intermediate stuffs will be kept alive to the end of the replay execution. This CL fixes this issue.