Workaround an issue in golang 1.10.3 where a 4GB file is truncated.#2141
Merged
AWoloszyn merged 1 commit intogoogle:masterfrom Aug 20, 2018
Merged
Workaround an issue in golang 1.10.3 where a 4GB file is truncated.#2141AWoloszyn merged 1 commit intogoogle:masterfrom
AWoloszyn merged 1 commit intogoogle:masterfrom
Conversation
ben-clayton
reviewed
Aug 13, 2018
Contributor
ben-clayton
left a comment
ben-clayton
left a comment
There was a problem hiding this comment.
Is there a golang bug created?
Can we have some comments in here explaining what's going on? Perhaps move the hack out to a separate function and have it documented?
Contributor
Author
|
The golang was in the first comment. (As well as commit comment). |
AWoloszyn
force-pushed
the
workaround-go
branch
from
24f58fd to
4b35553
Compare
AWoloszyn
force-pushed
the
workaround-go
branch
from
4b35553 to
b54b5cf
Compare
ben-clayton
approved these changes
Aug 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golang/go#26923