Vulkan: Fix bugs about linear images#2127
Merged
qining merged 1 commit intogoogle:masterfrom Aug 8, 2018
Merged
Conversation
1. When piping the image data to UI for the texture view, if the image is linear and has row pitch, depth pitch larger than a tightly packed blob, we need to cut off the extra data. 2. For MEC, when pulling image data at the tracing side, if the image is linear, we may need to change the image level pool size, and when mapping the data to the pool, consider the row pitch and depth pitch.
AWoloszyn
approved these changes
Aug 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When piping the image data to UI for the texture view, if the image
is linear and has row pitch, depth pitch larger than a tightly packed
blob, we need to cut off the extra data.
For MEC, when pulling image data at the tracing side, if the image is
linear, we may need to change the image level pool size, and when
mapping the data to the pool, consider the row pitch and depth pitch.