gapic: Move RPC logic from the views into the models#2120
Merged
pmuetschard merged 8 commits intogoogle:masterfrom Aug 2, 2018
Merged
gapic: Move RPC logic from the views into the models#2120pmuetschard merged 8 commits intogoogle:masterfrom
pmuetschard merged 8 commits intogoogle:masterfrom
Conversation
This model is responsible for loading the geometry mesh data to be shown in the geometry view. This is a refactoring change, which moves the RPC logic out of the view into a model class.
This model is responsible for loading the memory data and observation ranges. This is a refactoring change, which moves the RPC logic out of the view into a model class. As a side-effect, fixes some timing issues in the memory view. Also: collapses observation, read and write ranges so that the observation drop-down doesn't explode on draw calls that read from the application pool and the read/write highlights don't have random gaps.
Renames the Thumbnails model to ImagesModel (Images is already used in multiple places, sigh) and gives it the ability to load textures and framebuffers.
pmuetschard
added a commit
to pmuetschard/gapid
that referenced
this pull request
Aug 3, 2018
pmuetschard
added a commit
that referenced
this pull request
Aug 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for most RPC calls requiring a replay device and cleans up a blurry separation of concerns.