Overdraw: Check for format support and convert if necessary#2097
Merged
AWoloszyn merged 4 commits intogoogle:masterfrom Aug 3, 2018
Merged
Overdraw: Check for format support and convert if necessary#2097AWoloszyn merged 4 commits intogoogle:masterfrom
AWoloszyn merged 4 commits intogoogle:masterfrom
Conversation
Contributor
|
Am I right in thinking you're getting information about the trace device, storing this in the capture as an extra, and then using this to determine what you should do for replay? If so, we should chat. |
Contributor
|
Hi Sean. I've filed #2101 to track my concerns here. I know this is your last week, so I won't block this. |
Contributor
Author
|
Thanks Ben, I agree it's not ideal. If we were to loosen the "replay on original device" restriction at some point I don't think the modifications to this would be too complex. |
AWoloszyn
approved these changes
Aug 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also requires adding to the extras on vkEnumeratePhysicalDevices to check what formats the device supports. I set it up to just get the format support for all formats, but if that is too expensive this feature only needs to know support for the stencil formats.