Add an option to GAPID to disable unknown extensions.#2082
Merged
AWoloszyn merged 1 commit intogoogle:masterfrom Jul 25, 2018
Merged
Add an option to GAPID to disable unknown extensions.#2082AWoloszyn merged 1 commit intogoogle:masterfrom
AWoloszyn merged 1 commit intogoogle:masterfrom
Conversation
ben-clayton
approved these changes
Jul 24, 2018
Contributor
ben-clayton
left a comment
ben-clayton
left a comment
There was a problem hiding this comment.
Code looks good, but presubmits are failing.
pmuetschard
reviewed
Jul 24, 2018
Member
pmuetschard
left a comment
pmuetschard
left a comment
There was a problem hiding this comment.
Java stuff looks good.
What about GLES?
gapii/cc/spy_base.h
Outdated
| track_memory::MemoryTracker mMemoryTracker; | ||
| #endif // TARGET_OS | ||
|
|
||
| // This is true if we should not show disabled extensions to the application. |
Member
There was a problem hiding this comment.
nit: this comment was hard for me to parse :) I think it be better phrased as "If true, we will hide disabled extensions from the application."
Contributor
Author
|
@ben-clayton Thanks, I hadn't run the presubmits locally because this was done on my windows machine. I will pull on Linux and fix that. |
AWoloszyn
force-pushed
the
disable-unknown
branch
from
577238f to
2527eb5
Compare
Contributor
Author
|
@pmuetschard According to Ben, GLES doesn't advertise unknown extensions, so this should be a NO-op I will open a bug to make the option... optional. (Similar to disablePCS) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.