Use framebuffer extent in depth aspect copy, fixes #2071#2072
Merged
AWoloszyn merged 1 commit intogoogle:masterfrom Jul 23, 2018
Merged
Use framebuffer extent in depth aspect copy, fixes #2071#2072AWoloszyn merged 1 commit intogoogle:masterfrom
AWoloszyn merged 1 commit intogoogle:masterfrom
Conversation
sean-purcell
force-pushed
the
fix-overdraw-crash
branch
from
fc634ef to
2ad435e
Compare
AWoloszyn
approved these changes
Jul 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The depth-aspect copying assumed both the original depth image and the new depth-stencil image were the same size, which wasn't true when the original depth image was larger than the framebuffer. This limits the copy to just the framebuffer area.