Add Pipeline as a ResourceType and implement it for VkPipeline's#2069
Merged
AWoloszyn merged 4 commits intogoogle:masterfrom Aug 10, 2018
Merged
Add Pipeline as a ResourceType and implement it for VkPipeline's#2069AWoloszyn merged 4 commits intogoogle:masterfrom
AWoloszyn merged 4 commits intogoogle:masterfrom
Conversation
apazylbe
reviewed
Jul 18, 2018
cmd/gapit/flags.go
Outdated
| } | ||
| PipelineFlags struct { | ||
| Gapis GapisFlags | ||
| At flags.U64Slice `help:"command/subcommand index to get the memory after. Empty for last"` |
Contributor
Author
|
@AWoloszyn KhronosGroup/SPIRV-Reflect#56 has been merged so this is ready to go |
SPIRV-Reflect offers tools to analyze the interface exposed by a spirv module. It's used here to parse the descriptor sets that a given entry point of a module uses.
AWoloszyn
reviewed
Aug 3, 2018
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
This looks great, If you can rebase and squash some of the commits, once the bots are green I will merge it.
sean-purcell
force-pushed
the
descriptor-sets
branch
from
6111267 to
7f8ffb4
Compare
AWoloszyn
approved these changes
Aug 10, 2018
AWoloszyn
added a commit
to AWoloszyn/gapid
that referenced
this pull request
Aug 10, 2018
AWoloszyn
added a commit
that referenced
this pull request
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline's ResourceData returns their shaders and their bound data. The Vulkan implementation relies on https://github.com/chaoticbob/SPIRV-Reflect, although until KhronosGroup/SPIRV-Reflect#56 and KhronosGroup/SPIRV-Reflect#58 are merged, https://github.com/iburinoc/SPIRV-Reflect is being used as upstream.
Additionally, a gapit verb has been added to access the functionality. It prints out data on the most-recently bound pipeline for either graphics or compute, given a point in a trace.