Implement draw calls per frame and add it to gapit/stats#2031
Merged
AWoloszyn merged 2 commits intogoogle:masterfrom Jul 12, 2018
Merged
Implement draw calls per frame and add it to gapit/stats#2031AWoloszyn merged 2 commits intogoogle:masterfrom
AWoloszyn merged 2 commits intogoogle:masterfrom
Conversation
AWoloszyn
reviewed
Jul 11, 2018
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
Looks good to me. Although you will have to rebase.
For Vulkan, it creates a dependency graph for the synchronization primitives and uses that to determine which draw calls are complete. For other APIs it just assumes that all commands are blocking and executed in order.
sean-purcell
force-pushed
the
drawcalls-per-frame
branch
from
9a7e10e to
8a5d2c1
Compare
Contributor
Author
|
Rebased |
AWoloszyn
approved these changes
Jul 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Vulkan a dependency graph of the synchronization primitives is created and used to determine which draw calls are run when. For other APIs, it's assumed that the commands are executed synchronously. Since Vulkan annotates
vkQueueSubmitwith@draw_call,@executed_drawwas added to indicate that a command is a draw call only when executed as a subcommand (e.g. forvkCmdDraw).