Vulkan: Fix Device Lost error due to using wrong queue for querypools#2022
Merged
qining merged 1 commit intogoogle:masterfrom Jun 28, 2018
Merged
Vulkan: Fix Device Lost error due to using wrong queue for querypools#2022qining merged 1 commit intogoogle:masterfrom
qining merged 1 commit intogoogle:masterfrom
Conversation
AWoloszyn
approved these changes
Jun 28, 2018
Contributor
Author
|
Manually tests for the builds on all three platforms, and all passed. (And this CL should not make any difference for builds). Submitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rebuilding state, using a wrong queue to recreate query pools and their states may result into device lost error and crash or hang the whole replay.