Merged
Conversation
do: Add config option for msys2.
Add java bin to path for tests.
shell: Be case-insensitive for environment keys.
cc: fixup alloca issues.
cmake: pass down python paths to subbuilds.
Fix up host executable suffixes. Quote GOPATH so it isn't split into lists by cmake Fork add_llvm_symbol_exports to deal with windows shell. Add missing libraries to the interceptor lib.
All compiles now.
Change-Id: I4553d749cabf278fe2cbc431d8aa44b5c6c2bb76
Change-Id: I8f1ae44693e83359ab7361a18d57cf98ea1dfcc1
Windows ADB doesn't like the flag being passed as a whole string, instead pass a separated <ty> <key> <val> args.
Fixes tracing on windows.
Stops the client being built every build.
Attempting to static-initialize an unused variable with the result of a function call leads to hilarity, as it appears the inlined body is using unallocated memory.
ianthehat
approved these changes
Feb 24, 2017
Contributor
ianthehat
left a comment
ianthehat
left a comment
There was a problem hiding this comment.
Once you have deleted the warnings...
Contributor
Author
|
Done |
Closed
This was referenced Oct 21, 2019
purvisa-at-google-com
pushed a commit
to purvisa-at-google-com/gapid
that referenced
this pull request
Feb 26, 2020
- Identify a counter selection by counter id rather than the combinition of name and start time ts. - It will avoid losing track of the selection when quantization do some approximations on the time. - Bug 1: http://b/147922469, google#5. - Bug 2: http://b/149959272, google#2. - Bug 3: http://b/149959272. google#1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now builds and runs.