Fix for linear image with preinitialized intial layout#1960
Merged
qining merged 2 commits intogoogle:masterfrom Jun 6, 2018
Merged
Fix for linear image with preinitialized intial layout#1960qining merged 2 commits intogoogle:masterfrom
qining merged 2 commits intogoogle:masterfrom
Conversation
1) If an image has linear tiling and has initial layout set to PREINITIALIZED, all its subresources data pool will be linked back to the bound device memory, no new pool will be created for those subresources. 2) If an image has linear tiling and has initial layout set to PREINITIALIZED, and it can not be used as TRANSFER_DST, render target or imageStore target, its data will be primed by maping memory and flush map memory ranges.
Contributor
Author
|
Most of the changes in image_primer.go is just to return 'better' errors. The only real change in that file is |
AWoloszyn
approved these changes
Jun 6, 2018
Contributor
Author
|
Windows and Mac builds are tested locally, all passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an image has linear tiling and has initial layout set to
PREINITIALIZED, all its subresources data pool will be linked back to
the bound device memory, no new pool will be created for those
subresources.
If an image has linear tiling and has initial layout set to
PREINITIALIZED, and it can not be used as TRANSFER_DST, render target or
imageStore target, its data will be primed by maping memory and flush
map memory ranges.