Cleaned up a bunch of error message in Vulkan.#1948
Merged
AWoloszyn merged 1 commit intogoogle:masterfrom Jun 4, 2018
Merged
Conversation
Instead of returning a normal fmt.Errorf(), we now return a proper service.ErrDataUnavailable. This allow the UI to show a proper error message unstead of just a panic in the log view.
pmuetschard
approved these changes
Jun 1, 2018
ben-clayton
approved these changes
Jun 1, 2018
Contributor
ben-clayton
left a comment
ben-clayton
left a comment
There was a problem hiding this comment.
Are these all expected to happen with any given user data?
Contributor
Author
|
They are all certainly POSSIBLE with some user data. We don't expect most of them in a correctly written program, but I think we can hit them all normally. With Qining getting the validation layers together, I am hoping that we can pipe any of the other errors that are "real" errors out more cleanly, and in one spot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of returning a normal fmt.Errorf(), we now return
a proper service.ErrDataUnavailable. This allow the
UI to show a proper error message unstead of just a
panic in the log view.