Add a workaround for some Linux drivers.#1896
Merged
AWoloszyn merged 1 commit intogoogle:masterfrom May 22, 2018
Merged
Conversation
ben-clayton
reviewed
May 22, 2018
Contributor
ben-clayton
left a comment
ben-clayton
left a comment
There was a problem hiding this comment.
Can we do this with another driver blacklist?
We can get a crash when cleaning an instance in some circumstances with Vulkan drivers on Linux. If we force the Loader to keep an instance alive, then we won't run into this problem. The downside is that we leak a single instance.
AWoloszyn
force-pushed
the
linux-workaround
branch
from
08f34f8 to
6723c41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can get a crash when cleaning an instance in some
circumstances with Vulkan drivers on Linux.
If we force the Loader to keep an instance alive, then
we won't run into this problem. The downside is that we
leak a single instance.