gles: Log compat errors to the report view.#1741
Merged
ben-clayton merged 1 commit intogoogle:masterfrom Mar 12, 2018
Merged
Conversation
Few people will look in the log view to find the reason why shader conversion is going wrong.
AWoloszyn
approved these changes
Mar 12, 2018
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
Maybe it is worth it to log in both places?
Contributor
Author
|
It already does. For regular replay (non-find-issues) it'll log. Before we were logging these errors multiple times. |
Contributor
|
SGTM |
pmuetschard
approved these changes
Mar 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few people will look in the log view to find the reason why shader conversion is going wrong.