Vulkan: Handle D24 format correctly#1735
Merged
qining merged 3 commits intogoogle:masterfrom Mar 9, 2018
Merged
Conversation
qining
force-pushed
the
fix-depth-data-storage-transfer
branch
from
86c9475 to
0b6375b
Compare
For D24 format with either X8 or S8 channel, the depth element size is different for copying through buffer and storing in the image. We need to manually strip the MSB byte when processing the data if the data is retrieved through buffer image copy. sits on top of google#1728
qining
force-pushed
the
fix-depth-data-storage-transfer
branch
from
0b6375b to
0bfb3ea
Compare
AWoloszyn
approved these changes
Mar 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For D24 format with either X8 or S8 channel, the depth element size is
different for copying through buffer and storing in the image. We need
to manually strip the MSB byte when processing the data if the data is
retrieved through buffer image copy.