For storage bit images, we still need to prime their data by copying#1728
Merged
qining merged 1 commit intogoogle:masterfrom Mar 9, 2018
Merged
For storage bit images, we still need to prime their data by copying#1728qining merged 1 commit intogoogle:masterfrom
qining merged 1 commit intogoogle:masterfrom
Conversation
AWoloszyn
approved these changes
Mar 8, 2018
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
I would just check the windows build first.
qining
force-pushed
the
fallback-storage-image
branch
2 times, most recently
from
ffc05eb to
71d9d78
Compare
The fallback mode should only be dropped when the feature is implemented
qining
force-pushed
the
fallback-storage-image
branch
from
71d9d78 to
514de6b
Compare
qining
added a commit
to qining/gapid
that referenced
this pull request
Mar 8, 2018
For D24 format with either X8 or S8 channel, the depth element size is different for copying through buffer and storing in the image. We need to manually strip the MSB byte when processing the data if the data is retrieved through buffer image copy. sits on top of google#1728
qining
added a commit
to qining/gapid
that referenced
this pull request
Mar 8, 2018
For D24 format with either X8 or S8 channel, the depth element size is different for copying through buffer and storing in the image. We need to manually strip the MSB byte when processing the data if the data is retrieved through buffer image copy. sits on top of google#1728
qining
added a commit
to qining/gapid
that referenced
this pull request
Mar 9, 2018
For D24 format with either X8 or S8 channel, the depth element size is different for copying through buffer and storing in the image. We need to manually strip the MSB byte when processing the data if the data is retrieved through buffer image copy. sits on top of google#1728
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback mode should only be dropped when the feature is implemented