Skip tracking the data dependency of destroyed framebuffer images#1657
Merged
qining merged 3 commits intogoogle:masterfrom Mar 1, 2018
Merged
Skip tracking the data dependency of destroyed framebuffer images#1657qining merged 3 commits intogoogle:masterfrom
qining merged 3 commits intogoogle:masterfrom
Conversation
AWoloszyn
approved these changes
Feb 28, 2018
AWoloszyn
suggested changes
Feb 28, 2018
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
Can we do this in the api file instead?
I would rather remove them from the LastDrawState on destroy, which will make the api file more correct.
qining
force-pushed
the
skip-destroied-frame-image
branch
from
69afd3f to
fde7fe4
Compare
Contributor
Author
|
Updated the api file in 595063b. Also the image views used in descriptor sets are invalidated. |
qining
force-pushed
the
skip-destroied-frame-image
branch
from
595063b to
834cc7b
Compare
ben-clayton
changed the title
AWoloszyn
approved these changes
Mar 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.