Skip to content

Hacks to get windows compiling#1

Closed
AWoloszyn wants to merge 1 commit intowindowsfrom
windows-hacks
Closed

Hacks to get windows compiling#1
AWoloszyn wants to merge 1 commit intowindowsfrom
windows-hacks

Conversation

@AWoloszyn
Copy link
Contributor

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@AWoloszyn
Copy link
Contributor Author

Just FYI: This compiled fine with CMake 3.7.2. So no updates to CMake are required.

@ben-clayton
Copy link
Contributor

I've taken all the bits I think should be kept from this and clean up the rest.
We still need an Admin console, but I think I can change do to use Junctions instead of symlinks to fix this.

@ben-clayton ben-clayton deleted the windows-hacks branch March 4, 2017 17:14
purvisa-at-google-com pushed a commit to purvisa-at-google-com/gapid that referenced this pull request Feb 26, 2020
 - Identify a counter selection by counter id rather than the combinition of name and start time ts.
 - It will avoid losing track of the selection when quantization do some approximations on the time.
 - Bug 1: http://b/147922469, google#5.
 - Bug 2: http://b/149959272, google#2.
 - Bug 3: http://b/149959272. google#1.
AWoloszyn pushed a commit that referenced this pull request Mar 12, 2020
…#96)

 - When CPU Panel and Process Panel are under summary mode with time 
quantization (showing graph rather than slices), allow selection behavior as well.
 - A very useful use case enabled by this PR would be 1.zooming out and
 have an overview, 2.select a peak point denoting high CPU utilization
 in graph, 3.click 'f'or 'm' to quickly zoom/mark.
 - Bug: http://b/147922469. #1.
AWoloszyn pushed a commit that referenced this pull request Mar 12, 2020
 - Bug: http://b/147922469. #1.
pmuetschard pushed a commit that referenced this pull request Jun 11, 2020
…#96)

 - When CPU Panel and Process Panel are under summary mode with time 
quantization (showing graph rather than slices), allow selection behavior as well.
 - A very useful use case enabled by this PR would be 1.zooming out and
 have an overview, 2.select a peak point denoting high CPU utilization
 in graph, 3.click 'f'or 'm' to quickly zoom/mark.
 - Bug: http://b/147922469. #1.
pmuetschard pushed a commit that referenced this pull request Jun 11, 2020
 - Bug: http://b/147922469. #1.
pmuetschard pushed a commit that referenced this pull request Jun 11, 2020
 - Add selection behavior to Frame Event Panel, GPU Queue Panel
 and Thread Panel under time quantization.
 - Remove generic typed key in selection framework.
 - In Replay Profiler, set slice id with real perfetto query result.
 - Allow zooming for zero duration signals in Frame Event Panel.
 - Show full name at hovering for Surface Flinger track.
 - Set mouse cursor to hand when hanging over clickable area.
 - Bug: http://b/147922469. #1.
purvisa-at-google-com pushed a commit that referenced this pull request Sep 29, 2022
This bug may happen when AGI has Memory tab checked, but not put at front.

When block memory UI tries to repaint, it will 1.check repainting area, 2.
calculate repainting memory range accordingly, 3.query the server to load the
memory range.
In AGI, we have been using gc.getClipping() to do the step #1 for quite some
time, but recently we find that it will not do #1 correctly when the Memory tab
is hidden in the back, and thus the following steps will get wrong and cause
incorrect server query. (It's possible but not sure, that SWT handles gc.getClipping()
differently in newer version and thus this bug surfaces recently.) This PR tries
to do the step #1 based on another data source and thus solve the problem.

Test: This bug may happen when AGI has Memory tab checked, but not put at
front. Reproduced on MacOS BigSur.
Bug: b/181012589.
purvisa-at-google-com pushed a commit that referenced this pull request Sep 29, 2022
Add a "collect power rail data" option in System Profiler's config dialog
if the device in selection has the capability. And for a given System Profile 
trace, display captured power rail data in counter track format, if the data 
exists.

Bug: b/177067971, #1.
Test: will need certain devices for testing, the device requirement is in the 
bug ticket's #8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants