Declare instead of define variable in header file.#224
Merged
ebiggers merged 1 commit intogoogle:masterfrom May 10, 2020
Etrnls:master
Merged
Declare instead of define variable in header file.#224ebiggers merged 1 commit intogoogle:masterfrom Etrnls:master
ebiggers merged 1 commit intogoogle:masterfrom
Etrnls:master
Conversation
Collaborator
|
Thanks, this looks good. I'm guessing you're using gcc 10 (which was just released), and this bug broke the build because gcc 10 defaults to |
This fixes link error with gcc 10 which defaults to -fno-common
Contributor
Author
|
Yes this is to fix build with gcc 10. |
Collaborator
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.