Conversation
ebiggers
reviewed
May 5, 2020
Collaborator
ebiggers
left a comment
ebiggers
left a comment
There was a problem hiding this comment.
Can you please put the explanation in the commit message, not just in the pull request description? The pull request description gets lost on merge.
Also, this fix is actually needed for any 32-bit build, right?
| } | ||
|
|
||
| ioc := unix.FS_IOC_REMOVE_ENCRYPTION_KEY | ||
| ioc := uintptr(unix.FS_IOC_REMOVE_ENCRYPTION_KEY) |
Collaborator
There was a problem hiding this comment.
This makes the cast to uintptr below redundant. Can you remove that one?
ebiggers
pushed a commit
that referenced
this pull request
May 9, 2020
Since v0.2.6, fscrypt only builds for 64-bit systems. E.g. trying to build on Raspbian fails with the following error: $ go get github.com/google/fscrypt/cmd/fscrypt # github.com/google/fscrypt/keyring go/src/github.com/google/fscrypt/keyring/fs_keyring.go:231:6: constant 3225445912 overflows int go/src/github.com/google/fscrypt/keyring/fs_keyring.go:235:7: constant 3225445913 overflows int Fix it by making the 'ioc' variable have type uintptr. [EB - removed the later cast to uintptr that became unnecessary, and added explanation to commit message.]
Collaborator
|
Updated and merged as c576433. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, trying to build on Raspbian fails with the following error: