Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Collaborator

This should have been done as part of #553; it would have avoided #556.

Since there have been several other recent desktop-related fixes, this
requires a new enough version to pick them up as well to reduce the
chance of people hitting them.

This should have been done as part of google#553; it would have avoided google#556.

Since there have been several other recent desktop-related fixes, this
requires a new enough version to pick them up as well to reduce the
chance of people hitting them.
Copy link

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Collaborator Author

Looks like I broke testbed on Windows (maybe I didn't do a sufficiently clean build) with the recent change and hadn't noticed. Landing this since that's not a regression, and I'll file a bug to fix testbed tomorrow.

@stuartmorgan-g stuartmorgan-g merged commit c782938 into google:master Sep 12, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants