This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Update Windows project for ephemeral dir #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter-desktop-embedding
that referenced
this pull request
Sep 12, 2019
This should have been done as part of google#553; it would have avoided google#556. Since there have been several other recent desktop-related fixes, this requires a new enough version to pick them up as well to reduce the chance of people hitting them.
stuartmorgan-g
added a commit
that referenced
this pull request
Sep 12, 2019
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter-desktop-embedding
that referenced
this pull request
Sep 12, 2019
Fixes wrapper source path updates missed in google#553.
stuartmorgan-g
added a commit
that referenced
this pull request
Sep 12, 2019
Fixes wrapper source path updates missed in #553.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Windows builds for the breaking change in
flutter/flutter#40194
Note: plugins continue to hard-code the cache dir instead of using
FLUTTER_EPHEMERAL_DIR since currently they share the generated
properties file, but need a project-local copy of the cache. That
whole structure needs to be reworked, so the fact that it's
currently hard-coded isn't worth trying to fix right now
(e.g., by making FLUTTER_EPHEMERAL_DIR relative).