This repository was archived by the owner on Dec 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 607
Update macOS projects for new plugin tooling #411
Merged
stuartmorgan-g
merged 15 commits into
google:master
from
stuartmorgan-g:example-plugin-cocoapods
May 31, 2019
Merged
Update macOS projects for new plugin tooling #411
stuartmorgan-g
merged 15 commits into
google:master
from
stuartmorgan-g:example-plugin-cocoapods
May 31, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables consuming the plugin via CocoaPods using the same plugin management used for iOS. The project and support files to build it as a stand-alone library are still present, but will be removed later.
Reworks projects for the changes in flutter/flutter#33608 Adds an extra layer of xcconfig indirection, so that there's a clear distinction between the xcconfigs that are entirely human-managed, and the configs that Flutter will manage (which is useful for Pod handling, where Flutter needs to add configuration-specific xcconfig changes).
Collaborator
Author
|
(The commit history is a mess since this was developed incrementally with a lot of manual steps later replaced by tool output, pausing to do things in separate PRs then merging them back in, etc. and it didn't seem worth the effort to clean up since it'll be squashed on commit anyway.) |
jonahwilliams
approved these changes
May 31, 2019
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half of updating for flutter/flutter#33636
For example:
GeneratedPluginRegistrant, as with a default iOS project.
For testbed:
For example_plugin:
For all other plugins:
attempt to treat them as pods and fail.
The second half will be updating the other plugins to pods;
that's left as a follow-up to limit the scope of this patch.