Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Collaborator

First half of updating for flutter/flutter#33636

For example:

  • Switched from placeholder PluginRegistrant to empty.
    GeneratedPluginRegistrant, as with a default iOS project.

For testbed:

  • Same change as to example/ as a starting point.
  • Removed the direct dependency on example_plugin.
  • Ran 'flutter run', which created the rest of the changes.

For example_plugin:

  • Removed the Xcode project and framework-related files.
  • Updated structure and file naming to match iOS plugin format.
  • Added a podfile.

For all other plugins:

  • Commented out macosPrefix so that the new tooling won't
    attempt to treat them as pods and fail.

The second half will be updating the other plugins to pods;
that's left as a follow-up to limit the scope of this patch.

Enables consuming the plugin via CocoaPods using the same plugin
management used for iOS.

The project and support files to build it as a stand-alone library are
still present, but will be removed later.
Reworks projects for the changes in
flutter/flutter#33608

Adds an extra layer of xcconfig indirection, so that there's a clear
distinction between the xcconfigs that are entirely human-managed, and
the configs that Flutter will manage (which is useful for Pod handling,
where Flutter needs to add configuration-specific xcconfig changes).
@stuartmorgan-g
Copy link
Collaborator Author

(The commit history is a mess since this was developed incrementally with a lot of manual steps later replaced by tool output, pausing to do things in separate PRs then merging them back in, etc. and it didn't seem worth the effort to clean up since it'll be squashed on commit anyway.)

Copy link

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@stuartmorgan-g stuartmorgan-g merged commit bfb32f9 into google:master May 31, 2019
@stuartmorgan-g stuartmorgan-g deleted the example-plugin-cocoapods branch May 31, 2019 20:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants