This repository was archived by the owner on Dec 3, 2025. It is now read-only.
[linux/windows] Cap the minimum pixel ratio to 1 #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
suggested changes
Jan 28, 2019
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
For the checkin comment, it should say standard resolution, not high resolution. High resolution monitors are exactly the case where we do want non-1 pixel rations.
library/common/glfw/embedder.cc
Outdated
| double dpi = state->window_pixels_per_screen_coordinate * | ||
| state->monitor_screen_coordinates_per_inch; | ||
| double pixel_ratio = dpi / kDpPerInch; | ||
| if (pixel_ratio < 1) pixel_ratio = 1; |
Collaborator
There was a problem hiding this comment.
This can all become:
double pixel_ratio = std::max(dpi / kDpPerInch, 1.0);
It would be good to add a comment above that line about why this done (i.e., that scaling down on standard resolution monitors gives undesirable results).
stuartmorgan-g
changed the title
Avoids generating a UI that is too small in high resolution monitors.
Contributor
Author
|
PTAL! |
stuartmorgan-g
approved these changes
Jan 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids generating a UI that is too small in standard resolution monitors. #222