Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Collaborator

  • Clearly separates out and documents the variables that are most likely
    to need to change if copying the example app.
  • Better differentiate between paths that are relative to the example
    and paths that are relative to the FDE repository, since apps using
    FDE would not be expected to be in the same directory the way the
    example is.
  • Add a minimal "release" mode that enables that flag to disable Dart
    asserts, as on macOS and Windows.

- Clearly separates out and documents the variables that are most likely
  to need to change if copying the example app.
- Better differentiate between paths that are relative to the example
  and paths that are relative to the FDE repository, since apps using
  FDE would not be expected to be in the same directory the way the
  example is.
- Add a minimal "release" mode that enables that flag to disable Dart
  asserts, as on macOS and Windows.
- Remove the output directory override that puts the example app in the
  same output directory as the GN build (when building with GN).
  Combining them makes it less clear what's specific to the example,
  and what's part of building the library itself.
# limitations under the License.

# Example-specific variables.
# To modify this Makefile for a different application, these are the values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 👍

@stuartmorgan-g stuartmorgan-g merged commit 255592d into google:master Jan 22, 2019
@stuartmorgan-g stuartmorgan-g deleted the example-build-improvements-linux branch February 6, 2019 18:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants