Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Conversation

@jbg
Copy link
Contributor

@jbg jbg commented Jan 16, 2019

Fix: #234

Update the bundle ID for FlutterEmbedder.framework to match the change at flutter/engine#7503

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jbg
Copy link
Contributor Author

jbg commented Jan 16, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we normally don't worry about backwards compatibility, this is such a minor thing that I'd prefer not to break version compat just for it. We can add temporary code to try loading using the old bundle ID if this fails, with a TODO to remove it after the next version incompatibility.

(I'll add that to the patch tomorrow, unless you want to do it before then, since the engine change had landed and breaks using Flutter head on Mac)

@jbg
Copy link
Contributor Author

jbg commented Jan 17, 2019

added support for loading with the old ID if loading with the new ID fails.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@stuartmorgan-g stuartmorgan-g merged commit 1d90f97 into google:master Jan 17, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid bundle identifier io.flutter.flutter_embedder

3 participants