This repository was archived by the owner on Dec 3, 2025. It is now read-only.
[linux/windows] Add BasicMessageChannel #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements BasicMessageChannel, adds MessageCodec, and makes JsonMessageCodec public. Converts the key event handler from using BinaryMessenger directly to using a BasicMessageChannel to send events now that it's available.
awdavies
approved these changes
Jan 9, 2019
Contributor
awdavies
left a comment
awdavies
left a comment
There was a problem hiding this comment.
lgtm, just a little confused about some impl details.
|
|
||
| // Registers a handler that should be called any time a message is | ||
| // received on this channel. | ||
| void SetMessageHandler(MessageHandler<T> handler) const { |
Contributor
There was a problem hiding this comment.
I'm a bit confused about what this does. It doesn't look like it gets called anywhere? Is this just due to the implementation of the key event handler/
Collaborator
Author
There was a problem hiding this comment.
Right, the key event handler is send-only, so never does this. I just didn't want to add MessageChannel without half of its functionality.
It does the same thing SetMethodCallHandler does on MethodChannel, just without the extra structure assumed on the message.
franciscojma86
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements BasicMessageChannel, adds MessageCodec, and makes
JsonMessageCodec public.
Converts the key event handler from using BinaryMessenger directly to
using a BasicMessageChannel to send events now that it's available.