[glfw] Add dpi calculation to glfw embedder #204
Conversation
|
This PR also includes capitalization of all callbacks, as discussed in #187 . |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
In giving this one last test I ran it on Linux via Chrome Remote Desktop, and discovered that it was broken if the monitor's size information isn't available (in which case the returned size is zero, per docs). I added handling of that case (and factored all that into a function since I think this comment got lost).
With that now fixed, it looks good!
|
It's probably worth considering whether the width/height passed to FlutterWindowCreate should be changed in a follow-up from being interpreted as screen coordinates to Flutter logical pixels, so that the physical window isn't so small on high-DPI monitors (without the embedder having to do all the same calculations). I'm not sure if there's a convention on Linux/Windows for default application window sizes to scale based on DPI. |
|
Great! Thanks for all the feedback and helping in getting this solved. |
2 participants
This PR adds pixel_ratio calculations to the GLFW embedder.
Fixes #32
Replaces #187