Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Fix Travis config #201

Merged
stuartmorgan-g merged 10 commits into from
Jan 4, 2019
Merged

Fix Travis config #201

stuartmorgan-g merged 10 commits into from
Jan 4, 2019

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Jan 4, 2019 •
edited
Loading

  • Fix the filename, so Travis is actually active.
  • Various fixes to make the builds green.

@stuartmorgan-g stuartmorgan-g changed the title Fix Travis config filename Fix Travis config Jan 4, 2019
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jan 4, 2019

It turns out that the reason Travis wasn't running on the initial PR wasn't that it had to be landed on master first, but that the filename was wrong. Doh!

But as expected, there were other issues as well.

krisgiesing
krisgiesing approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@krisgiesing krisgiesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit 7d968e6 into google:master Jan 4, 2019
@stuartmorgan-g stuartmorgan-g deleted the travis-name-fix branch January 4, 2019 16:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@krisgiesing krisgiesing krisgiesing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g @krisgiesing