Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Collaborator

Merges the GLFW-based embedding implementations for Windows and
Linux into a single shared implementation. At this point the implementations
are largely identical, and having two copies is increasingly a maintenance
burden.

Originally they were separate since they were intended to be throw-away,
and their development proceeded at different speeds. Now that they have
reached parity, and there's a possibility that the GLFW implementation
will be longer-lived than initially expected, having one copy that's testable
on several platforms should simplify development.

Copy link
Contributor

@krisgiesing krisgiesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion to add explanatory comments.

@stuartmorgan-g stuartmorgan-g merged commit a304a86 into google:master Jan 2, 2019
@stuartmorgan-g stuartmorgan-g deleted the glfw-merge branch January 8, 2019 18:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants