This repository was archived by the owner on Dec 3, 2025. It is now read-only.
[linux] Align C++ plugin structure with Flutter #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note: please wait for me to land this rather than landing it once it's approved, because it's a breaking change for PR #161 and I have a patch I'll want to push there at the same time as landing this. |
stuartmorgan-g
force-pushed
the
cpp-plugin-alignment
branch
from
124214e to
f3fd1e0
Compare
Collaborator
Author
|
Rebased to account for 161 (now depends on #194) |
Eliminates Plugin as the primary interface point, and instead moves to a MethodChannel-based model. This eliminates the need for void* types in the interfaces, allowing a move to full type safety (via templates) for all the classes related to channels. Additionally, the plugin creation and registration system now matches the Flutter structure on iOS and Android, using static registration of a plugin class with a PluginRegistrar. The desktop registrar currently has minimal functionality, but it can be extended over time. This is collapsed into one large patch in order to minimize the number of API-breaking changes.
stuartmorgan-g
force-pushed
the
cpp-plugin-alignment
branch
from
69f6943 to
45f9dd2
Compare
franciscojma86
approved these changes
Jan 7, 2019
Contributor
franciscojma86
left a comment
franciscojma86
left a comment
There was a problem hiding this comment.
LGTM with a few nits
library/include/flutter_desktop_embedding/engine_method_result.h
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // PluginRegistrar: | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
It's a heading for both of the following methods, so I separated it so that it doesn't appear to be associated only with AddPlugin.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates Plugin as the primary interface point, and instead moves to a
MethodChannel-based model. This eliminates the need for void* types in
the interfaces, allowing a move to full type safety (via templates) for
all the classes related to channels.
Additionally, the plugin creation and registration system now matches
the Flutter structure on iOS and Android, using static registration of a
plugin class with a PluginRegistrar. The desktop registrar currently has
minimal functionality, but it can be extended over time.
This is a breaking change for any Plugin implementation, as well as
application-level code that was calling AddPlugin. It is collapsed into
one large patch in order to minimize the number of API-breaking changes.
This essentially completes issue #102 for Linux.