This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Move most C++ library code to common/ and include/ #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preperatory change for Windows using all of this code. Since it will be shared between multiple platforms, it should live in a shared location. Because the GN build flattens the headers in the generated out/include/, some files have #if/#else branches for #includes. Once there is a final decision on whether to use GN, this can be re-evaluated.
Collaborator
Author
franciscojma86
approved these changes
Dec 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preperatory change for Windows using all of this code. Since
it will be shared between multiple platforms, it should live in a shared
location.
Because the GN build flattens the headers in the generated out/include/,
some files have #if/#else branches for #includes. Once there is a final
decision on whether to use GN, this can be re-evaluated.