This repository was archived by the owner on Dec 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 607
[macOS] Add FLEEventChannel #174
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from google/flutter-desktop-embedding
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Contributor
Author
|
|
CLAs look good, thanks! |
Closed
stuartmorgan-g
suggested changes
Dec 29, 2018
Contributor
Author
|
I have modified the code, please review again. |
Merge from google/flutter-desktop-embedding@master
Merge from google/flutter-desktop-embedding@master
- Add a missing nullability specifier. - Use simplified nullability annotations when possible. - clang-format using project style file. - Add braces to conditionals to match project style. - Add new header to umbrella header.
stuartmorgan-g
approved these changes
Jan 8, 2019
Collaborator
|
Sorry for the long initial delay in reviewing; for some reason I had been thinking this was gated on the engine texture change, rather than a stand-alone piece that could land at any time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for communicating with
a EventChannel on the Flutter side. #173