Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Conversation

@cloudwebrtc
Copy link
Contributor

@cloudwebrtc cloudwebrtc commented Dec 17, 2018

Adds support for communicating with
a EventChannel on the Flutter side. #173

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@cloudwebrtc
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@cloudwebrtc cloudwebrtc changed the title [macOS] Add FLEEventChannel (#173) [macOS] Add FLEEventChannel Dec 17, 2018
@cloudwebrtc
Copy link
Contributor Author

cloudwebrtc commented Jan 4, 2019

I have modified the code, please review again.

cloudwebrtc and others added 3 commits January 4, 2019 22:24
Merge from google/flutter-desktop-embedding@master
Merge from google/flutter-desktop-embedding@master
- Add a missing nullability specifier.
- Use simplified nullability annotations when possible.
- clang-format using project style file.
- Add braces to conditionals to match project style.
- Add new header to umbrella header.
@stuartmorgan-g
Copy link
Collaborator

Sorry for the long initial delay in reviewing; for some reason I had been thinking this was gated on the engine texture change, rather than a stand-alone piece that could land at any time.

@stuartmorgan-g stuartmorgan-g merged commit a7c25b3 into google:master Jan 8, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants