This repository was archived by the owner on Dec 3, 2025. It is now read-only.
[macos] Add BasicMessageChannel #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further API alignment (issue google#102). Adds support for communicating with a BasicMessageChannel on the Flutter side.
Collaborator
Author
|
The diff mostly did a good job with the file splitting, but one exception to be aware of is that MethodCall is just moved, not new code. |
| @@ -69,14 +69,14 @@ extern NSString const *_Nonnull FLEMethodNotImplemented; | |||
| * | |||
| * The arguments, if any, must be encodable using this channel's codec. | |||
| */ | |||
| - (void)invokeMethod:(nonnull NSString *)method arguments:(id _Nullable)arguments; | |||
Contributor
There was a problem hiding this comment.
Should the qualifiers in FLEBasicMessageChannel.h change as well?
Collaborator
Author
There was a problem hiding this comment.
The nullability annotations on FLEBasicMessageChannel are using this style. The typedefs (as with those at the top of this file) can't, because this form isn't usable in all language constructions.
franciscojma86
approved these changes
Dec 5, 2018
Contributor
franciscojma86
left a comment
franciscojma86
left a comment
There was a problem hiding this comment.
LGTM with one qualifiers question
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further API alignment (issue #102). Adds support for communicating with
a BasicMessageChannel on the Flutter side.
Also splits apart the files related to codecs and channels to be one class
per file. They were originally combined to match the Flutter iOS file structure,
but that has proven to hinder project navigation more than it helps with
cross-referencing.
Moved classes have been cleaned up to be more consistent about using
nullability declarations only on interfaces, not implementations.