-
Notifications
You must be signed in to change notification settings - Fork 607
Windows: text input #161
Windows: text input #161
Conversation
… remove binary dependency on jsoncpp and compile from source instead.
…r functions, text input plugin headers / source into a glfw director
Collapses common/src/ to just common/ since there's no longer another directory in common/. Also moves linux embedder.h into include/linux to unify include dir.
|
Pushed changes that fix Linux. It ended up being kind of ugly since making my GN include/ aggregation not flatten the structure was non-trivial, so there are a few conditional includes in the Linux code now. Once build systems is settled I can improve the situation. Some things to note:
|
I decided to test this branch out on Windows to see if I broke anything, and then thought I'd check this. It does work, as expected: https://github.com/stuartmorgan/flutter-desktop-embedding/tree/windows-key-events I'll land that as a follow-up patch to avoid adding even more things to this patch though. |
@stuartmorgan will do Sent with GitHawk |
|
All done, awaiting input. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few minor things (I'd fix them myself, but I don't have my Windows machine at the moment and don't want to accidentally break something with an untested change).
|
Oh, and if you want to do the honors you could remove the final caveat from the main README in this patch :) |
|
OK, all done here! |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Bring the Linux embedder keyboard input support over to the Windows embedder.