Adds opacity slider option to color panel #155
Conversation
|
is this ready/do you need a reviewer? |
|
I need a reviewer. I can't assign reviewers :( |
Hopefully this is fixed now. I thought just having you listed as a collaborator would give you the ability to request reviews, but it sounds like not; you have write access now which should do it. |
|
Comments addressed, PTAL! Also, I can assign reviewers now, thanks :) |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Just some small nits, then this is good to go!
| if ([call.methodName isEqualToString:@(plugins_color_panel::kShowColorPanelMethod)]) { | ||
| [self showColorPanel]; | ||
| BOOL showAlpha = YES; | ||
| if ([call.arguments isKindOfClass:[NSDictionary class]]) { |
There was a problem hiding this comment.
If this isn't true then the call is malformed, so I'd prefer that if the check fails the code NSLog an error message, then call result(FLEMethodNotImplemented); and return early.
|
Done, PTAL! |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM modulo re-running clang-format after the latest changes.
Feel free to submit once you upload that change. Remember to do "squash and merge" so that you're submitting a single change instead of all the incremental patches. (You'll need to clean up the commit message in the resulting text field since by default it'll just stick together the commit messages of all the incremental patches, which isn't very useful.)
4 participants
Left it as an optional parameter to mimic the native color choosers