Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Collaborator

Speculative fix for issue #132

@stuartmorgan-g
Copy link
Collaborator Author

I hit #132 myself, and noticed that the frameworks weren't actually listed as link dependencies (which moves this into "how did this work before" territory). I can't figure out how to recreate the issue again, so I'm not certain that this fixes it, but it did seem to resolve it when I did have the build failure.

Copy link
Contributor

@krisgiesing krisgiesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisgiesing
Copy link
Contributor

The libraries are listed in the project config as "embedded binaries", maybe that implicitly declared a dependency in Xcode 9.x but not in 10?

@stuartmorgan-g
Copy link
Collaborator Author

A clean build without this change still works for me though, so it's not just a 10 vs. 9 issue. Possibly something implicit that's broken by building before and after the repo re-org somehow? I don't have a good explanation for why that would be though.

But having the explicit dependency certainly seems like the right thing regardless.

@stuartmorgan-g stuartmorgan-g merged commit cf7ceeb into google:master Nov 5, 2018
@stuartmorgan-g stuartmorgan-g deleted the mac-link-fix branch December 12, 2018 19:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants