-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix native_type non-native_inline fields, add tests #8655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aardappel
merged 4 commits into
google:master
from
souryavarenya:fix/native-type-non-inline
Aug 3, 2025
Merged
Fix native_type non-native_inline fields, add tests #8655
aardappel
merged 4 commits into
google:master
from
souryavarenya:fix/native-type-non-inline
Aug 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@aardappel Could you please review this? A couple of notes:
|
aardappel
reviewed
Aug 3, 2025
Collaborator
|
Collaborator
|
Please see the errors in CI, it is actually checking for differences between the python script and CMake which you are violating :) |
Contributor
Author
|
@aardappel Gotcha! I removed |
aardappel
approved these changes
Aug 3, 2025
Collaborator
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve #6770
This PR takes inspiration from #8003, and adds a couple more improvements.