[Swift] Moves capacity from storage to struct #8650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustiikhalil
force-pushed
the
moves-var-capacity-to-buffer-instead-of-storage
branch
from
c685dd1 to
18fc02f
Compare
Moves capacity into the internal buffer instead of storing it within the class Cleans up capacity usage within the lib, and uses overflow operators
mustiikhalil
force-pushed
the
moves-var-capacity-to-buffer-instead-of-storage
branch
from
18fc02f to
2de3f77
Compare
Collaborator
Author
|
@aardappel a quick tiny for reference counting within swift access to the capacity variable. |
aardappel
approved these changes
Jul 29, 2025
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Oct 28, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `FlatBuffers` to `v25.9.23` ### Why are the changes needed? To bring the latest bug fixes and improvements like `Windows` support. - https://github.com/google/flatbuffers/releases/tag/v25.9.23 (2025-09-23) - google/flatbuffers#8484 - google/flatbuffers#8577 - google/flatbuffers#8622 - google/flatbuffers#8637 - google/flatbuffers#8643 - google/flatbuffers#8650 - google/flatbuffers#8649 - google/flatbuffers#8702 ### Does this PR introduce _any_ user-facing change? No. There is no behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #254 from dongjoon-hyun/SPARK-54045. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
mustiikhalil
deleted the
moves-var-capacity-to-buffer-instead-of-storage
branch
mustiikhalil
restored the
moves-var-capacity-to-buffer-instead-of-storage
branch
mustiikhalil
deleted the
moves-var-capacity-to-buffer-instead-of-storage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capacityfrom storage to_internalbufferandbufferimplementations in bothFlexbuffersandFlatbuffersto avoid extra unexpected reference counts.