[Swift] Fixes load from misaligned raw pointer #8649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustiikhalil
force-pushed
the
fix-fatal-error-load-misaligned-pointer
branch
from
2cfb449 to
5bb5d0b
Compare
Collaborator
Author
|
@aardappel this also can be merged |
Fixes misaligned pointer by using the bindMemory method used internally in bytebuffer
mustiikhalil
force-pushed
the
fix-fatal-error-load-misaligned-pointer
branch
from
5bb5d0b to
fdfd316
Compare
mustiikhalil
commented
Jul 27, 2025
aardappel
approved these changes
Jul 29, 2025
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Oct 28, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `FlatBuffers` to `v25.9.23` ### Why are the changes needed? To bring the latest bug fixes and improvements like `Windows` support. - https://github.com/google/flatbuffers/releases/tag/v25.9.23 (2025-09-23) - google/flatbuffers#8484 - google/flatbuffers#8577 - google/flatbuffers#8622 - google/flatbuffers#8637 - google/flatbuffers#8643 - google/flatbuffers#8650 - google/flatbuffers#8649 - google/flatbuffers#8702 ### Does this PR introduce _any_ user-facing change? No. There is no behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #254 from dongjoon-hyun/SPARK-54045. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR fixes a bug where we store a memory pointer to the underlying buffer memory and try to load it as an aligned value. However it seems that there was an issue with that in swift 6.1. This is fixed by using the
_bb.read()method that assumes the type and loads it instead.Closes #8648