[TS] Fix relative paths for exports #8517
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
c++
codegen
trumully
force-pushed
the
fix-typescript-namespace
branch
from
c533489 to
ede7634
Compare
trumully
force-pushed
the
fix-typescript-namespace
branch
3 times, most recently
from
cdc9df3 to
df4a042
Compare
Fixes an issue where exports were using incorrect relative paths for >=3 namespace levels. This is fixed by making the starting range of the namespace components relative to the amount of components.
trumully
force-pushed
the
fix-typescript-namespace
branch
from
df4a042 to
708a90a
Compare
|
@dbaileychess @aardappel is there anything we can do to get this PR moving? |
|
@bjornharrtell it looks like you're an active contributor to the typescript port, do you have any time to review this? (Thanks, if so) |
bjornharrtell
left a comment
bjornharrtell
left a comment
There was a problem hiding this comment.
Active is a stretch. 😅 But this looks sensible to me.
|
@bjornharrtell thanks! CI looks unrelated, merging. |
|
@aardappel Do you happen to know when this might be released? |
|
I haven't done releases in a looong time.. @dbaileychess is doing those. |
|
Fair enough, I should have looked closer before tagging you! Thank you for your work on this project, I have enjoyed using it! |
5 participants
Fixes an issue #7898 where exports were using incorrect relative paths for >=3 namespace levels. This is fixed by making the starting range of the namespace components relative to the number of components.
I have also added tests for this fix.